search

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.51k stars 436 forks source link

refactor(logging): remove unused channels #5569

Closed tomcat323 closed 2 months ago

tomcat323 commented 2 months ago

Problem

The channel logger was removed as part of: https://github.com/aws/aws-toolkit-vscode/pull/5564. As a result the 'AWS toolkit' and 'Amazon Q' channels are no longer used, but they still show up in IDE output channels. They should be removed to maintain cleanliness.

Solution

Remove these two channels in extension.ts so they don't get initiated.
Also remove input to logger activation since it's unused.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 2 months ago

This pull request modifies files in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

jpinkney-aws commented 2 months ago

It looks like the build issues are probably because several places use global.outputChannel but now when they access that variable its undefined

tomcat323 commented 2 months ago

Upon further discussion, the output channel should be kept for "normal" messages, to show output from various features for normal application usage. This pull request is now closed