refactor(codewhisperer): refactor UTG code path and add test coverage

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.51k stars 436 forks source link

refactor(codewhisperer): refactor UTG code path and add test coverage #5590

Closed Will-ShaoHua closed 1 month ago

Will-ShaoHua commented 2 months ago

Problem

complicate regex being used which is not scalable and hard to understand
stale and complicate code which lacks readability
test coverage

Solution

java

https://github.com/user-attachments/assets/46877435-057c-4c17-af91-4ffa27d93a0c

https://github.com/user-attachments/assets/356aa23d-a7ce-4f38-b0ff-32d8c0da8611

no supported (kotlin)

https://github.com/user-attachments/assets/2e344169-3515-4de7-8379-32cbafaab194

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Will-ShaoHua commented 2 months ago

[done] will upload a functional feature test screen recording

Will-ShaoHua commented 1 month ago

That was implemented in the new assertIsTestFile function. I think it would be preferable to add that variant to testUtil.ts, but doesn't need to block this for now.

sgtm, i will add this to testUtil

justinmk3 commented 1 month ago

sgtm, i will add this to testUtil

Oh, I didn't see this. I have a PR already for that https://github.com/aws/aws-toolkit-vscode/pull/5660

Will-ShaoHua commented 1 month ago

Oh, I didn't see this. I have a PR already for that

gotcha, thanks Justin :)!