fix(lambda): save params before running sam command when --watch is selected

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.52k stars 447 forks source link

fix(lambda): save params before running sam command when --watch is selected #6089

Open mbfreder opened 3 days ago

mbfreder commented 3 days ago

Problem

When --watch flag is used, the sync process remains alive. The region and stack_name info get written to config file only after the process finishes. This means customer would not be able to see (or refresh) the latest deployed resoures during the sync process.

Solution

Write to samconfig.toml before running sam sync

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 3 days ago

This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
- Note: beta or "experiment" features that have active users should announce fixes in the changelog.
- If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

mbfreder commented 3 days ago

One test is failing here but not on my local machine. Investigating this.