search

aws / aws-tools-for-powershell

The AWS Tools for PowerShell lets developers and administrators manage their AWS services from the PowerShell scripting environment.
Apache License 2.0
235 stars 78 forks source link

Unclear Confirm message from Install-AWSToolsModule #132

Closed FireInWinter closed 3 years ago

FireInWinter commented 4 years ago

Expected Behavior If I run: Install-AWSToolsModule -Name AWS.Tools.S3 I would expect to get a Confirm message like:

Are you sure you want to perform this action?
Performing the operation "Install-AWSToolsModule" on target "Version '4.0.4.0' of module 'AWS.Tools.S3'".

Current Behavior Instead we get the message that really doesn't tell you anything other than it is trying to install something from AWS, but you can't tell what.

Confirm
Are you sure you want to perform this action?
Performing the operation "Install-AWSToolsModule" on target "AWS Tools version 4.0.4.0".

Possible Solution Just have it modeled on the Confirm message of Install-Module as it makes a lot more sense.

Steps to Reproduce (for bugs) Running on AWS Linux with PowerShell core 7.0rc2 Ran: Install-Module AWS.Tools.Installer Import-Module AWS.Tools.Installer Install-AWSToolsModule -Name AWS.Tools.S3

klaytaybai commented 4 years ago

Thanks for the feedback

ashishdhingra commented 3 years ago

Hi @FireInWinter,

Good evening.

Looking this issue at high level, it appears to be a simple change. However, there is an ambiguity if you try to install multiple modules using the single command, e.g., Install-AWSToolsModule -Name AWS.Tools.S3,AWS.Tools.EC2. What should be the behavior in this case? We can install multiple modules and listing each line for each module could pollute the interactive output. Please help revalidate your requirement.

Thanks, Ashish

github-actions[bot] commented 3 years ago

This issue has not recieved a response in 2 weeks. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled.