Closed aberus closed 1 month ago
Thanks for the PR.
All the csproj files are generated by the generator during the build process. So the changes that are made directly to AWS.Tools.EKS.csproj
will be lost after the build. Here's the location of the template where the change needs to be made.
Before the change is made, the SDK team will need to review if the licensing of YamlDotNet
is compatible with aws licensing. if yes, then the decision needs to be made if it make sense to take the dependency in the common module or service specific module.
We will discuss with the team and get back to you soon.
We have discussed as a team and decided that there's not enough confidence in taking a runtime dependency on YamlDotNet
. We're not aware of a reliable way to provide this functionality without a YAML parser so there does not appear to be a path forward to implement this request.
Description
This cmdlet returns an object containing the configured current-context and the path of the updated kubeconfig file. It provides similar functionality to AWS CLI Command
aws eks update-kubeconfig
. It lossy based onGet-EKSCluster
cmdlet.Motivation and Context
Kubeconfig file generation for EKS #62
Testing
Example 1
Screenshots (if appropriate)
Types of changes
Checklist
We require a second engineer to validate the PR before merging
New/existing dependencies impact assessment, if applicable
Added dependency YamlDotNet
License