search

aws / aws-tools-for-powershell

The AWS Tools for PowerShell lets developers and administrators manage their AWS services from the PowerShell scripting environment.
Apache License 2.0
238 stars 79 forks source link

Cmdlets do not honor proxy environment variables #44

Closed jakauppila closed 8 months ago

jakauppila commented 5 years ago

When using the various cmdlets contained within the module, I cannot simply utilize my HTTP/HTTPS-NO_PROXY environment variables for the HTTP calls that commands are doing.

Expected Behavior

Module cmdlets should respect HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment variables of my system

Current Behavior

I must explicitly set the proxy via Set-AWSProxy passing in those values from the environment variables.

Context

When we utilize the module within some of our Jenkins pipelines it would be easier if we could specify the proxy configurations at the very top level and just let it propagate down to all of our HTTP calls whether they be Groovy, raw Powershell calls, or Powershell SDK module calls.

matteo-prosperi commented 5 years ago

Thanks for reporting this. Marking as feature request with backward compatibility concerns.

jakauppila commented 5 years ago

As a potential workaround to the backwards incompatibility, could an environment variable be utilized to effectively opt-in to the behavior?

AWS_INHERIT_SYSTEM_PROXY

github-actions[bot] commented 2 years ago

We have noticed this issue has not recieved attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

jakauppila commented 2 years ago

This would still be useful

github-actions[bot] commented 1 year ago

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

jakauppila commented 1 year ago

This would still be useful

ashishdhingra commented 1 year ago

Similar issue for AWS SDK for .NET: https://github.com/aws/aws-sdk-net/issues/1977

dscpinheiro commented 8 months ago

Today's release of PowerShell (4.1.488) uses the AWS .NET SDK 3.7.720.0, where support for the http_proxy and https_proxy environment variables was added: https://github.com/aws/aws-sdk-net/blob/main/changelogs/SDK.CHANGELOG.2024.md#377200-2024-01-04-1956-utc

Note that proxies set via Set-AWSProxy will still take precedence (for backwards compatibility).

github-actions[bot] commented 8 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.