search

aws / aws-xray-daemon

The AWS X-Ray daemon listens for traffic on UDP port 2000, gathers raw segment data, and relays it to the AWS X-Ray API.
Apache License 2.0
191 stars 69 forks source link

Fix for Dockerfile smell DL3006 #197

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Issue #, if available: None

Description of changes: Hi! The Dockerfile placed at "Dockerfile.amazonlinux" contains the best practice violation DL3006 detected by the hadolint tool.

The smell DL3006 occurs when the image tag for the base image is missing. In this pull request, we propose a fix for that smell generated by our fixing tool. We have verified that the patch is correct before opening the pull request. To fix this smell, specifically, we use a heuristic approach that selects the most probable version tag for the given base image. In detail, it selects the most recent image tag which corresponds to the same image digest that currently corresponds to the "latest" tag, used by default when pulling the image from DockerHub if a specific image tag is missing.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.