search

aws / aws-xray-dotnet-agent

The official AWS X-Ray Auto Instrumentation Agent for .Net.
Apache License 2.0
23 stars 15 forks source link

add dependency: Microsoft Coreclr Lib #7

Closed edyin closed 4 years ago

edyin commented 4 years ago

Issue #, if available:

Description of changes: This is Microsoft Coreclr Lib. It is a required dependency to build profiler. The code is not written by us. We provide it so that customer don't need to download it when they try to build the profiler.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

edyin commented 4 years ago

Vendoring in 213K lines of code seems like something we really need to avoid for the maintenance of this repository (how are we going to keep up with updates to this code?). I can't even see the entire PR here.

Can you confirm, this is not installed when a user installs .NET Framework or .NET Core on their computer? Requiring installation of the standard .NET package for developing something for .NET seems reasonable to me.

Otherwise how about either

  • Git submodule
  • Script that downloads and unzips it into a gitignored directory

? That sounds good, we probably can just list this as pre-requirement to build the proflier in README, And customer can download it themselves. @lupengamzn how to you think about it?

edyin commented 4 years ago

Close this pull request, since we changed to let customer download the coreclr Lib themselves. Will open another PR to add instruction in README.