search

aws / aws-xray-java-agent

The official AWS X-Ray Auto Instrumentation Agent for Java.
Apache License 2.0
42 stars 18 forks source link

Jackson dependency & Shadow #106

Closed greensmith closed 2 years ago

greensmith commented 3 years ago

Hello there, we're seeing an issue with our Springboot app where the jackson depedancy is being changed by the agent and causing our app to fail.

I'm aware from looking through the code that com.github.johnrengelman.shadow is used to prevent this but I am not familiar enough with gradle to know how this has been configured in relation to the jackson library.

Any guidance would be appreciated.

willarmiros commented 3 years ago

Hi @greensmith,

Could you post the complete error you are experiencing? It's possible we are not shading the jackson dependency correctly and you are using a newer version that is causing incompatibilities.

Regardless, if you are interested in a Java auto-instrumentation solution for tracing I would recommend checking out the OpenTelemetry Java Auto-instrumentation agent. It instruments many more libraries than the X-Ray agent, and you can still easily send data to the X-Ray backend with it by following this guide: https://aws-otel.github.io/docs/getting-started/java-sdk/trace-auto-instr

greensmith commented 2 years ago

@willarmiros thank you for taking the time to reply, sorry its taken a while to respond but I've been away. the specific errors were identical to those highlighted in this issue for heroku agent, https://github.com/heroku/heroku-java-metrics-agent/issues/9

will take a look at the OpenTelemetry agent and see if that is any different.

greensmith commented 2 years ago

Hi, just to add to this, for anyone who is interested, we have been using the OpenTelemetry agent to successfully capture our application traces, so thank you very much for that suggestion.

I'll close this issue