search

aws / aws-xray-java-agent

The official AWS X-Ray Auto Instrumentation Agent for Java.
Apache License 2.0
42 stars 18 forks source link

I hope disco works with javaagent attach method #84

Closed sanghogu closed 2 years ago

sanghogu commented 3 years ago

Hello Sorry to open the issue again

The method that javaagent is started when the app is started executes the premain service logic, but the attach method does not work normally because it enters other service logic while the application is running Supporting the attach method makes the programming method more beautiful and free Please review positively. Thank

willarmiros commented 3 years ago

Hi @rhqnrehf,

Thanks for suggesting this, could you explain a little more what the limitations are that prevent the agent from being compatible with the JDK Attach API today? The underlying disco framework provides support for the Attach API, so can you use that along with our agent as a workaround for now?

sanghogu commented 3 years ago

Oh, if you use OpenJDK, you cannot use general Attach API. So, I use ea-agent-loader, and if I use this, all segments themselves are not created

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in next 7 days. Thank you for your contributions.