search

aws / aws-xray-sdk-dotnet

The official AWS X-Ray SDK for .NET.
Apache License 2.0
110 stars 64 forks source link

How about updating Least .NET Framework version to .NET452 #97

Open enif-lee opened 5 years ago

enif-lee commented 5 years ago

Hello there.

I have tried to contribute for adding some extensions (ex: NpgsqlHandler, MysqlHandler, Entity Framework Support). But The solution failed to build because of .net framework version.

.NET45 is officially end. So I can't download developer pack for 45. from .net download.

However, To learn code base of this project, I raised .net version to 452, finally I've succeed to build whole projects.

I would like to register this as a PR, What do you think about raising minimum .net framework version to 452?

Thank you. Best Regards,

srprash commented 5 years ago

Hi @enif-lee , A PR is always welcomed. Feel free to create one. We will review it and get it merged.

Thanks.