Fix typo (Metdata -> Metadata)

aws / aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.

Apache License 2.0

278 stars 117 forks source link

Fix typo (Metdata -> Metadata) #239

Closed aereal closed 4 years ago

aereal commented 4 years ago

Issue #, if available:

Description of changes:

ec2.Metdata type that introduced by #235 is maybe typo of ec2.Metadata.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

anuraaga commented 4 years ago

Actually, on second thought, let's leave Metdata as is, move it to the bottom of the file, and indicate it's deprecated, and add the new properly named, private struct. Since we don't return the type from an API, I think we can fix this without breaking semantic versioning

aereal commented 4 years ago

@anuraaga

Yeah, I have same concern about semantic versioning.

So changes I should make will be:

add a new metadata private type that has same structure as Metdata
indicates Metdata as deprecated

aereal commented 4 years ago

@anuraaga

Thanks for your quick review.

Fixed deprecated comment convention and test failing that occurred by name conflicts.