aws / aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.
Apache License 2.0
276 stars 117 forks source link

responseCapturer should implement the http.Flusher interface #254

Closed applike-ss closed 3 years ago

applike-ss commented 3 years ago

Hello,

we are using xray in our projects and also gin-gonic to serve requests via a rest api. Recently we wanted to add Server sent events to our projects which added the requirement to be able to flush the response writer, because otherwise the response would buffered instead of directly sent to the client after being rendered. We diagnosed the responseCapturer to be causing this, as our logs state: interface conversion: *xray.responseCapturer is not http.Flusher: missing method Flush. Would you accept a pull request to add the flush ability?

best regards, Sebastian Struß / justDice

applike-ss commented 3 years ago

i just realized that there is already a patch in place in a newer version. closing the ticket.