search

aws / aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.
Apache License 2.0
276 stars 117 forks source link

Use of retracted Brotli package due to downstream dependency #330

Closed a-h closed 2 years ago

a-h commented 2 years ago

Attempting to get v1.6.0 results in a warning about the brotli package.

$ go get github.com/aws/aws-xray-sdk-go/xray
go: warning: github.com/andybalholm/brotli@v1.0.1: retracted by module author: occasional panics and data corruption
go: to switch to the latest unretracted version, run:
        go get github.com/andybalholm/brotli@latest

This is due to downstream dependency on fasthttp:

$ go mod why github.com/andybalholm/brotli  
# github.com/andybalholm/brotli
# <my package - redacted>
github.com/aws/aws-xray-sdk-go/xray
github.com/valyala/fasthttp
github.com/andybalholm/brotli

fasthttp was updated to use v1.0.2 on the 17th May in this PR:

https://github.com/valyala/fasthttp/pull/1029 https://github.com/valyala/fasthttp/commit/5898006f5b926f30e6a629deefed8c4b432cc0c3

So, any version after https://github.com/valyala/fasthttp/releases/tag/v1.25.0 would work fine.

A version bump should do it.