search

aws / aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.
Apache License 2.0
276 stars 117 forks source link

Interface check for deprecated SQL methods blocks the contextual ones #340

Open crabtree opened 2 years ago

crabtree commented 2 years ago

According to the go database/sql documentation interfaces Queryer and Execer are deprecated. Current approach implemented in aws-xray-sdk-go checks interface compliance at the very top of the QueryContext and ExecContext. This seems to be incorrect, as the underlying driver implements the contextual methods it will never be called due to the fact that the processing will be terminated with an error driver.ErrSkip.

willarmiros commented 2 years ago

Fixed by #341, to close at next release.