search

aws / aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.
Apache License 2.0
276 stars 117 forks source link

Support for fasthttp.Client #360

Open joanlopez opened 2 years ago

joanlopez commented 2 years ago

Background

fasthttp is an alternative to Go's native net/http network library. It is written to be significantly more performant at scale; in some cases, it is ~10x faster than the standard library. It is used widely and is well-maintained.

Moreover, this project already have support for fasthttp handlers: issue & merged pull request.

The Ask

Therefore, it'd be helpful if aws-xray-sdk-go could work out-of-the-box with fasthttp client as well. The client implementation is different enough to make it not trivial to use as-is.

Links

fasthttp net/http-->fasthttp request adaptor

willarmiros commented 2 years ago

Hi @joanlopez - thanks for the feedback! We'd be happy to take a look at a PR for a new client instrumentation, however at this time we will not be able to add new instrumentations on our roadmap.

Alternatively, we would recommend you check out the AWS Distro for OpenTelemetry Go, which provides first-class fasthttp support and support for the X-Ray backend! https://aws-otel.github.io/docs/getting-started/go-sdk

We are always open to feedback that you can open here: https://github.com/aws-observability/aws-otel-go

joanlopez commented 2 years ago

Alternatively, we would recommend you check out the AWS Distro for OpenTelemetry Go, which provides first-class fasthttp support and support for the X-Ray backend! https://aws-otel.github.io/docs/getting-started/go-sdk

Sure, sounds like a great alternative! :) Could you please point out to any code example / documentation page with examples or information about how to instrumentate the SDK with the fasthtt, please? Thanks!