search

aws / aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.
Apache License 2.0
276 stars 117 forks source link

Fix vulnerability #378

Closed AbhilashVijayakumar closed 1 year ago

AbhilashVijayakumar commented 1 year ago

*Issue reported in our internal security scan - please refer screenshot and recommendation Screenshot 2022-09-14 at 12 02 37 PM

Description of changes: upgrade to aws-sdk-go@v1.44.97

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

atshaw43 commented 1 year ago

@AbhilashVijayakumar The tests are failing. Can you please take a look?

AbhilashVijayakumar commented 1 year ago

@AbhilashVijayakumar The tests are failing. Can you please take a look?

Updated unit test @atshaw43 commit https://github.com/aws/aws-xray-sdk-go/pull/378/commits/7f55dcee1cca4204110b02e56969883749d7f43b

AbhilashVijayakumar commented 1 year ago

@atshaw43 all tests are passing in https://github.com/SPHTech/aws-xray-sdk-go is the github actions in this repo pulling the incorrect repo to test against can help to review Screenshot 2022-10-18 at 5 22 06 PM Screenshot 2022-10-18 at 5 27 01 PM

atshaw43 commented 1 year ago

I pulled down the code locally and tested it and it ran fine. Can you kick off the tests again? I don't seem to have permission to.

atshaw43 commented 1 year ago

You might also try pulling the changes from this fork into yours and re-testing.

atshaw43 commented 1 year ago

I fixed the tests in a side pull request and merged them since I could not edit this one.

This PR can be closed.

https://github.com/aws/aws-xray-sdk-go/pull/390