aws / aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.
Apache License 2.0
276 stars 117 forks source link

Change workflow to use go v1.9 rather than v1 #396

Closed jj22ee closed 1 year ago

jj22ee commented 1 year ago

Issue #, if available: Workflow unit tests are failing in environments (windows-latest, 1) and (macos-latest, 1).

Description of changes: Since the AWS X-Ray SDK for Go is compatible with Go v1.9 and above, remove the unit tests for Go v1 and use Go v1.9

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

willarmiros commented 1 year ago

I think the Readme is outdated, Go v1.9 has been EOL for years. We just haven't updated the Go version in the readme as we've updated the supported versions.

"Go v1" simply tests the latest minor version of Go, we should keep that as part of the CI to ensure we're running against the latest version and fix any breaking changes introduced.