Closed aloababa closed 10 months ago
Can you add some unit tests for this? Some on the function level, and some at the segment level. By segment level I mean setting a URL on a segment and checking the JSON output when we convert it.
I've added TestRoundTripWithBasicAuth unit test.
I've updated the pull request.
Thanks for the response.
You will need to rebase with the upstream to merge this.
I rebased on master.
Issue #421
Description of changes:
Stripping basic auth password from url to avoid leak in xray traces.