search

aws / aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.
Apache License 2.0
276 stars 117 forks source link

omit URL's password when stringifying URL for segment name #422

Closed aloababa closed 10 months ago

aloababa commented 10 months ago

Issue #421

Description of changes:

Stripping basic auth password from url to avoid leak in xray traces.

atshaw43 commented 10 months ago

Can you add some unit tests for this? Some on the function level, and some at the segment level. By segment level I mean setting a URL on a segment and checking the JSON output when we convert it.

aloababa commented 10 months ago

I've added TestRoundTripWithBasicAuth unit test.

aloababa commented 10 months ago

I've updated the pull request.

Thanks for the response.

atshaw43 commented 10 months ago

You will need to rebase with the upstream to merge this.

aloababa commented 10 months ago

I rebased on master.