search

aws / aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.
Apache License 2.0
276 stars 117 forks source link

Remove the use of github.com/pkg/errors as its moved to Archived. #452

Closed csg-kdeepak closed 7 months ago

csg-kdeepak commented 8 months ago

The code is making use of the github.com/pkg/errors. The package has been moved to Public Archive and not being maintained anymore. Should be replaced by an available public package.

atshaw43 commented 7 months ago

Thanks for bringing this to our attention.

Our users could still be passing errors as stack traces from this library. We translate those errors into exceptions which can then be added to a segment (see below). Removing this translation would change behavior and, therefore, be a breaking change for customers still using it. We will have to wait until a major version change before implementing this. I am going to close this for now. It is something we can look into when we do another major version change.

https://github.com/aws/aws-xray-sdk-go/blob/master/strategy/exception/default_exception_formatting_strategy.go#L155