search

aws / aws-xray-sdk-java

The official AWS X-Ray Recorder SDK for Java.
Apache License 2.0
96 stars 99 forks source link

Adding Jakarta support #372

Closed atshaw43 closed 1 year ago

atshaw43 commented 1 year ago

Issue #, if available: https://github.com/aws/aws-xray-sdk-java/issues/364 The new version of Spring supports Jakarta instead of Javax.

Description of changes: Add a parallel set of classes for Jakarta for all Javax related files.

There are no business logic changes between Jakarta and Javax.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Attention: Patch coverage is 52.11864% with 113 lines in your changes missing coverage. Please review.

Project coverage is 58.12%. Comparing base (cbf9f62) to head (2bc6cf4). Report is 28 commits behind head on master.

Files Patch % Lines
...aws/xray/jakarta/servlet/AWSXRayServletFilter.java 52.51% 62 Missing and 23 partials :warning:
...strategy/jakarta/DynamicSegmentNamingStrategy.java 0.00% 18 Missing :warning:
...y/jakarta/servlet/AWSXRayServletAsyncListener.java 61.11% 6 Missing and 1 partial :warning:
...s/xray/strategy/jakarta/SegmentNamingStrategy.java 80.00% 2 Missing :warning:
...y/strategy/jakarta/FixedSegmentNamingStrategy.java 90.90% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #372 +/- ## ============================================ - Coverage 58.41% 58.12% -0.29% - Complexity 1229 1269 +40 ============================================ Files 133 138 +5 Lines 5011 5247 +236 Branches 589 633 +44 ============================================ + Hits 2927 3050 +123 - Misses 1814 1902 +88 - Partials 270 295 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

atshaw43 commented 1 year ago

Sample application

https://github.com/atshaw43/AWSXRaySpring6SampleApp