search

aws / aws-xray-sdk-java

The official AWS X-Ray Recorder SDK for Java.
Apache License 2.0
94 stars 98 forks source link

Remove usage of deprecated jackson property #391

Closed manofthepeace closed 9 months ago

manofthepeace commented 9 months ago

Description of changes: PropertyNamingStrategy.CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES is deprecated since Jackson 2.7 (2.12 is used). This was done to help potentially unblock https://github.com/quarkusio/quarkus/pull/37295

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (398ec05) 28.08% compared to head (c9a103b) 24.27%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #391 +/- ## ============================================ - Coverage 28.08% 24.27% -3.81% + Complexity 574 498 -76 ============================================ Files 138 138 Lines 5256 5256 Branches 635 635 ============================================ - Hits 1476 1276 -200 - Misses 3578 3797 +219 + Partials 202 183 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

atshaw43 commented 9 months ago

LGTM

For future note, I see we are testing the EntityImpl serialization here. https://github.com/aws/aws-xray-sdk-java/blob/398ec0542964b4d9b38c901385eda4d98da07cd4/aws-xray-recorder-sdk-core/src/test/java/com/amazonaws/xray/entities/EntityTest.java#L48