aws / aws-xray-sdk-node

The official AWS X-Ray SDK for Node.js.
Apache License 2.0
267 stars 155 forks source link

Oversampling Mitigation #541

Closed carolabadeer closed 1 year ago

carolabadeer commented 1 year ago

Issue #, if available: N/A

Description of changes: Implemented oversampling mitigation - added methods to create subsegments without sampling (control sampling decisions at the subsegment level) and an SQS message helper class

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Merging #541 (e99c271) into master (a1f4c79) will increase coverage by 0.36%. The diff coverage is n/a.

:exclamation: Current head e99c271 differs from pull request most recent head 95df8a6. Consider uploading reports for the commit 95df8a6 to get more accurate results

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   82.36%   82.73%   +0.36%     
==========================================
  Files          36       37       +1     
  Lines        1758     1784      +26     
==========================================
+ Hits         1448     1476      +28     
+ Misses        310      308       -2     
Impacted Files Coverage Δ
lib/env/sqs_message_helper.js 83.33% <0.00%> (ø)
lib/patchers/aws_p.js 80.26% <0.00%> (+0.53%) :arrow_up:
lib/segments/segment.js 80.81% <0.00%> (+1.05%) :arrow_up:
lib/segments/attributes/subsegment.js 79.26% <0.00%> (+1.34%) :arrow_up:
lib/env/aws_lambda.js 91.52% <0.00%> (+1.69%) :arrow_up:
lib/patchers/http_p.js 94.31% <0.00%> (+2.18%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

atshaw43 commented 1 year ago

Was this tested in Lambda directly?