search

aws / aws-xray-sdk-node

The official AWS X-Ray SDK for Node.js.
Apache License 2.0
271 stars 155 forks source link

Client doesn't check if middlewareStack is present on client and crashes #561

Closed mrjomp closed 1 year ago

mrjomp commented 1 year ago

https://github.com/aws/aws-xray-sdk-node/blob/a9d0cf9cbd0328e40f30554f61b4bd5fac08bafc/packages/core/lib/patchers/aws3_p.ts#L187

willarmiros commented 1 year ago

Hi @mrjomp - we don't check because middlewareStack is a required member of the Client object in the AWS SDK's TS definition, do you have a reproduction case of this error?

https://github.com/aws/aws-sdk-js-v3/blob/df1304fa/packages/types/src/client.ts#L32

carolabadeer commented 1 year ago

Closing as stale issue - please reopen if there are any further questions