search

aws / aws-xray-sdk-node

The official AWS X-Ray SDK for Node.js.
Apache License 2.0
267 stars 156 forks source link

Updated actions/checkout, actions/setup-node, and codecov package versions to fix CI #574

Closed carolabadeer closed 1 year ago

carolabadeer commented 1 year ago

Issue #, if available: N/A

Description of changes: PR build for Node 18.x started failing due to the latest version of npm not being used in the "Setup Node 18.x" step. 

npm ERR! enoent ENOENT: no such file or directory, open '/home/runner/work/aws-xray-sdk-node/aws-xray-sdk-node/node_modules/core/package.json'
npm ERR! enoent This is related to npm not being able to find a file.

Updating actions/checkout and actions/setup-node to v3 and adding the check-latest: true flag to ensure the latest npm version is being used resolved this error.

Codecov package used in "Report Coverage" step was also reporting a TypeError that was fixed in v3.8.3, see related issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Merging #574 (ccaab4f) into master (a476e2b) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ccaab4f differs from pull request most recent head cb4e545. Consider uploading reports for the commit cb4e545 to get more accurate results

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        1794     1794           
=======================================
  Hits         1496     1496           
  Misses        298      298

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.