search

aws / aws-xray-sdk-node

The official AWS X-Ray SDK for Node.js.
Apache License 2.0
267 stars 156 forks source link

Is http2 allowed to be passed to AWSXRay.captureHTTPsGlobal? #579

Open kitsunde opened 1 year ago

kitsunde commented 1 year ago

The type definition for captureHTTPsGlobal does not include http2. Is it supported?

export function captureHTTPsGlobal(mod: typeof https | typeof http, downstreamXRayEnabled?: boolean, subsegmentCallback?: httpSubsegmentCallback): void;
carolabadeer commented 1 year ago

Hi @kitsunde, The X-Ray Node SDK does not currently support instrumentation for HTTP2, which is why it is not included in the type definitions for captureHTTPs functions. However, there is an open feature request for support for HTTP2 in the opentelemetry-js repo, which I have followed up on. I would recommend keeping an eye on that issue to see if/when opentelemetry plans to support HTTP2 instrumentation, and we are always happy to review any feature contributions if you are open to making a PR!

kitsunde commented 1 year ago

I see thank you. Is the idea that X-Ray will not continue to be built upon beyond maintenance? The language and in the repo is a bit vague.

carolabadeer commented 1 year ago

HTTP2 instrumentation is not currently on our roadmap for instrumentation support, but we are still welcoming and reviewing any feature contributions for the X-Ray SDKs :)