aws / aws-xray-sdk-node

The official AWS X-Ray SDK for Node.js.
Apache License 2.0
267 stars 156 forks source link

[CI] Keep lerna version consistent. Test on Node20. And more. #597

Closed srprash closed 1 year ago

srprash commented 1 year ago

Problem

Recently lerna v7 got released and it broke our CI due to backward incompatible command. Upon investigation, I found that although we specify lerna v5.5.2 in our package.json, the latest version was being used for builds.

Solution

Use the lerna version that is defined in the package.json. This is currently v5.5.2 which can be used for our build without any problems. In the future, we may think of migrating to a newer mechanism as per this doc.

Changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Merging #597 (b19b777) into master (097e27e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head b19b777 differs from pull request most recent head d6d211a. Consider uploading reports for the commit d6d211a to get more accurate results

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        1794     1794           
=======================================
  Hits         1496     1496           
  Misses        298      298