aws / aws-xray-sdk-node

The official AWS X-Ray SDK for Node.js.
Apache License 2.0
267 stars 156 forks source link

fix(core): capture command data for SDK v3 clients #611

Closed danno-s closed 12 months ago

danno-s commented 1 year ago

Issue #, if available: #460

Description of changes: Changes based on @SergeyPoluektov's PR: #527 since it looks abandoned.

I simply validated their changes, and added the requested unit test to this PR. The test validates that command inputs and outputs get mapped correctly into the generated segments.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (e32dd95) 83.38% compared to head (375dba1) 83.38%.

:exclamation: Current head 375dba1 differs from pull request most recent head 6e3ae68. Consider uploading reports for the commit 6e3ae68 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #611 +/- ## ======================================= Coverage 83.38% 83.38% ======================================= Files 37 37 Lines 1794 1794 ======================================= Hits 1496 1496 Misses 298 298 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.