search

aws / aws-xray-sdk-node

The official AWS X-Ray SDK for Node.js.
Apache License 2.0
266 stars 155 forks source link

Add export for resolveManualSegmentParams to AWSXRay #628

Closed jasonterando closed 6 months ago

jasonterando commented 7 months ago

This PR adds an export for resolveManualSegmentParams to AWSRay. This is to allow access to that function from plugins/extensions published in the sdk_contrib

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b6fb649) 83.49% compared to head (51ea81e) 83.49%.

:exclamation: Current head 51ea81e differs from pull request most recent head b778942. Consider uploading reports for the commit b778942 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #628 +/- ## ======================================= Coverage 83.49% 83.49% ======================================= Files 37 37 Lines 1805 1805 ======================================= Hits 1507 1507 Misses 298 298 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jj22ee commented 6 months ago

Updated a comment. Thanks, LGTM