aws / aws-xray-sdk-node

The official AWS X-Ray SDK for Node.js.
Apache License 2.0
266 stars 155 forks source link

TraceId timestamp supports string starts with '0' #641

Closed mxiamxia closed 4 months ago

mxiamxia commented 4 months ago

Issue #, if available: If upstream is sending X-Ray like trace id but with timestamp section starts with 0, such as "1-0074e2eb-694001932729d04067bb5440" Actual, The bug is: the trace id is parsed to "1-74e2eb-694001932729d04067bb5440". Expected The expected behavior is: the trace id is parsed to "1-0074e2eb-694001932729d04067bb5440".

Description of changes: If the timestamp section in X-Ray like trace id less than 8 digits, pad 0s as prefix.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description of changes: Unit Test