aws / aws-xray-sdk-node

The official AWS X-Ray SDK for Node.js.
Apache License 2.0
266 stars 155 forks source link

Replace macos-latest with macos-13 for nodejs 14.x tests #649

Closed jj22ee closed 3 months ago

jj22ee commented 3 months ago

Issue #, if available: Failing workflow on macos-latest w/ nodejs 14: https://github.com/aws/aws-xray-sdk-node/actions/runs/9003814066/job/24971759228?pr=646

As of now, macos-latest provides only ARM hosts - https://github.com/actions/runner-images/issues/9741 https://github.com/actions/runner-images?tab=readme-ov-file#available-images Without workarounds, Node.js 14 isn't supported on ARM macos.

Description of changes: The fix in this PR is to test on macos-13 version instead

Testing: https://github.com/jj22ee/aws-xray-sdk-node/actions/runs/9086772809

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.