search

aws / aws-xray-sdk-python

AWS X-Ray SDK for the Python programming language
Apache License 2.0
329 stars 143 forks source link

Support For Ariadne #339

Open rmorshea opened 2 years ago

rmorshea commented 2 years ago

Ariadne is a popular GraphQL server for Python. It would be great if there were built-in support for Ariadne within this X-Ray SDK.

This snippet describing how to integrate Ariadne with OpenTelemetry could be used as a model for how to get something similar working with this X-Ray SDK.

rmorshea commented 2 years ago

I'd be willing to implement this myself given some guidance.

srprash commented 2 years ago

Hi @rmorshea Thanks for opening this feature request and offering to contribute. If possible, I think it would be worth it to open this request with opentelemetry python contrib. Opentelemetry python already has a broad array of library instrumentation and stable community support, as well as with ADOT, it is officially supported with X-Ray.

If you need this feature specifically in X-Ray SDK, we will be happy to work with you. :)

rmorshea commented 2 years ago

I'd be interested in a pursuing the X-Ray SDK solution for two reasons:

  1. I'm on a team within AWS - so no reason to go with a cloud-agnostic solution from what I can tell.
  2. Our team is relatively inexperienced with cloud infra so standing up ADOT seems like more than we can manage.