search

aws / chalice

Python Serverless Microframework for AWS
Apache License 2.0
10.67k stars 1.01k forks source link

Secrets Manager not supported? #811

Closed jpi-car closed 6 years ago

jpi-car commented 6 years ago

Directly mirroring from https://github.com/awslabs/aws-sam-local/issues/367, I'm having issues with deploying my Chalice app when I try to use Secrets Manager. When deployed, the app errors out with this error: module initialization error: Unknown service: 'secretsmanager'. I tried following the suggestion in the provided link above by using pip wheel boto3, and then placing the generated pip wheels inside the vendor folder, however this didn't solve the issue.

owenbrown commented 6 years ago

Please add support for secrets.

atimzhao commented 6 years ago

+1

stealthycoin commented 6 years ago

Not sure exactly what you mean by add support for this in Chalice. The runtime dependencies are entirely up to you. You can supply any version of botocore/boto3 by specifying it in requirements.txt.

Looks like secrets manager was added in this commit: https://github.com/boto/botocore/commit/861992908355de3fe34a5744c0bd04f1445c6ddd which corresponds to botocore 1.9.23.

So you just need botocore>=1.9.23 in your requirements.txt.

jpi-car commented 6 years ago

@stealthycoin Ah, haha. Thank you very much. That was a silly mistake of me. Closing.

ilyaGotfryd commented 2 years ago

While this issue is closed pulling values from Secrets Manager at the time of the deployment to reside as environment variables with an instance of Lambda is a common place pattern. It would be a proper feature to implement. I run into this need literally with every new project I push into production. Please reconsider this as a basic security requirement and not a frivolous want as indicated by response in this thread.