aws / codecatalyst-blueprints

Apache License 2.0
52 stars 19 forks source link

Enforcement of correct NVM/NPM version #319

Open agdimech opened 1 year ago

agdimech commented 1 year ago

I recently ran into an issue whereby .gitignore files were not being included in the tar.gz. This was due to the fact that I was using npm v9 instead of v6.

We should enforce/validate that the user is running the required version of nvm/npm before packaging to ensure correct bundling.

A potentials solution could be to add an engines entry into the root package.json specifying npm v6 i.e:


{
  "engines": {
    "npm": "^6"
  }
}
alexforsyth commented 10 months ago

Thats a great idea!