aws / connect-rtc-js

Provide softphone support to AmazonConnect customers when they choose to directly integrate with our API and not using our web app.
Apache License 2.0
79 stars 63 forks source link

handle empty ice candidate generated by Firefox 69.0b3 #49

Closed gargvk10 closed 5 years ago

gargvk10 commented 5 years ago

Issue #, if available: Firefox in its 69.0b3 generates empty ice candidate like onicecandidate {"candidate":"","sdpMid":"0","sdpMLineIndex":0,"usernameFragment":"abcd"} These type of candidate generates line like a= in sdp. Lines like a= in sdp causes signaling handshake to fail

Description of changes: We will check candidate is not empty before adding it into the ice collected list

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.