aws / connect-rtc-js

Provide softphone support to AmazonConnect customers when they choose to directly integrate with our API and not using our web app.
Apache License 2.0
79 stars 63 forks source link

Deprecation warning on RTC_PEER_CONNECTION_CONFIG sdpSemantics value plan-b #66

Closed Christian-Sesta closed 2 years ago

Christian-Sesta commented 3 years ago

My team noticed this warning appear in Chrome DevTools.

--

[Deprecation] Plan B SDP semantics, which is used when constructing an RTCPeerConnection with {sdpSemantics:"plan-b"}, is a legacy version of the Session Description Protocol that has severe compatibility issues on modern browsers. The standardized SDP format, "unified-plan", has been used by default since M72 (January, 2019). Dropping support for Plan B is targeted for M93 (Canary: July 15, 2021; Stable: August 24, 2021).

--

The cause seems to be connect-rtc-js using plan-b semantics instead of unified-plan.

connect-rtc-js/src/js/rtc_const.js
export const RTC_PEER_CONNECTION_CONFIG = {
 iceTransportPolicy: 'relay',
 rtcpMuxPolicy: 'require',
 bundlePolicy: 'balanced',
 sdpSemantics: 'plan-b'
};
aztalbot commented 2 years ago

Any update on this issue? The deprecation has been there for a long time, and from what I can tell not only affects this library, but also the out-of-the-box CCP. Now that it's broken in Chrome Canary and could cause wide breakage if introduced to stable Chrome, is there any schedule available for when Plan B might be removed from this library? Are there backend changes that need to happen that this library is waiting on?

marktheunissen commented 2 years ago

Looks like it's removed in the master branch as of 3 days ago, but they haven't cut a release yet. https://github.com/aws/connect-rtc-js/commit/262e9d947942c044835597c109c70555fb3b9d8d

Christian-Sesta commented 2 years ago

Looks like they have cut the new release @marktheunissen , @aztalbot. They also sent out emails about this change to all aws instances as I got them yesterday. Going to close this ticket for them now.