aws / containers-roadmap

This is the public roadmap for AWS container services (ECS, ECR, Fargate, and EKS).
https://aws.amazon.com/about-aws/whats-new/containers/
Other
5.21k stars 318 forks source link

[EKS] [fargate]: Allow custom node labels in eks fargate instances #1476

Open marcportabellaclotet-mt opened 3 years ago

marcportabellaclotet-mt commented 3 years ago

Community Note

Tell us about your request What do you want us to build? I would like to add custom node labels to eks fargate nodes Which service(s) is this request for? This could be Fargate, EKS,

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

In our scenario, we have some pods that are scheduled with specific node selector policy. We are using mutating webhooks to apply this nodeselector annotations in our pods. AFAIK, there is no option to add custom node labels to eks fargate nodes. These are the default labels :+1:

beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,eks.amazonaws.com/compute-type=fargate,failure-domain.beta.kubernetes.io/region=eu-central-1,failure-domain.beta.kubernetes.io/zone=eu-central-1a,kubernetes.io/arch=amd64,kubernetes.io/hostname=ip-10-253-45-6.eu-central-1.compute.internal,kubernetes.io/os=linux,topology.kubernetes.io/region=eu-central-1,topology.kubernetes.io/zone=eu-central-1a

and I would like to add my custom ones, to allow mutation webhooks work in our scenario.

Are you currently working around this issue?

It is something that we can't control.

mreferre commented 3 years ago

@marcportabellaclotet-mt a quick question to clarify the ask. Are you using these node labels to land pods on the proper nodes? I am asking because if this is the goal it may be incompatible with how Fargate works (and its current philosophy). Fargate provisions nodes on the fly to serve pods deployment requirements. When a node is provisioned on the fly EKS already knows it needs to use that node to deploy that pod (in fact it has provisioned that node for that purpose). A node is not provisioned "upfront" and used as a target "schedulable" capacity for future pods.

Or are you just saying there should be a mechanism to be able to tag that Fargate node with that specific label for consistency if a pod carried that requirement?

Thanks.

marcportabellaclotet-mt commented 3 years ago

As you comment in the second option, I am just saying there should be a mechanism to be able to tag that Fargate node with that specific label for consistency if a pod carried that requirement.

Thanks for your answer!

cdenneen commented 5 months ago

Any update to this request? I would like to have some labels applied to Fargate nodes as well so when running things like eks-node-viewer or other kubectl commands you can filter on or show columns with Fargate-profileName