aws / containers-roadmap

This is the public roadmap for AWS container services (ECS, ECR, Fargate, and EKS).
https://aws.amazon.com/about-aws/whats-new/containers/
Other
5.22k stars 321 forks source link

[EKS] [request]: Ability to change kube controller manager parameters such as '--terminated-pod-gc-threshold' #1544

Open hshabbar opened 3 years ago

hshabbar commented 3 years ago

Community Note

Tell us about your request What do you want us to build?

Ability to set values for kube controller manager parameters such as --terminated-pod-gc-threshold

Which service(s) is this request for? EKS

sidewinder12s commented 2 years ago

@mikestef9 Is the value that EKS uses for this flag documented anywhere?

dmegyesi commented 2 years ago

@mikestef9 Is the value that EKS uses for this flag documented anywhere?

You can check it in Cloudwatch when you enable the control plane logging. In my EKS 1.21 cluster it's: --terminated-pod-gc-threshold="12500"

sidewinder12s commented 2 years ago

That's long ago deleted, though I'll take that as its set to the default.

mtcode commented 2 years ago

Another flag that should be configurable is --horizontal-pod-autoscaler-tolerance. The default value is 0.1, or 10%, but there are use cases to make the value smaller (more sensitive, more responsive) or larger.

raravena80 commented 2 years ago

+1 we need this feature

ozcb commented 1 year ago

+1

adamdougal commented 1 year ago

Just to add to the list of parameters that we'd like configurable. --concurrent-horizontal-pod-autoscaler-syncs which is new in K8s 1.26.

Aym3nTN commented 10 months ago

Is there like any reason to not allow overriding this --terminated-pod-gc-threshold default value? it's really a pain to have to clean up those terminated pods manually or having a cronjob to do it...

parvez99 commented 2 months ago

Any plans of having this feature rolled out anytime soon ? This would be very helpful.

MedAzizTousli commented 2 weeks ago

+1 for this very important feature.

qxmips commented 2 weeks ago

+1