search

aws / copilot-cli

The AWS Copilot CLI is a tool for developers to build, release and operate production ready containerized applications on AWS App Runner or Amazon ECS on AWS Fargate.
https://aws.github.io/copilot-cli/
Apache License 2.0
3.52k stars 414 forks source link

SVC Init doesn't always register app with created namespace #2336

Open brogers-propstream opened 3 years ago

brogers-propstream commented 3 years ago

HI there! We just came across copilot and it's been a huge help, however, we've encountered numerous little bugs that are driving us mad.

The biggest detractor is that we tried to init a backend-service about 3 times now. Each time does not create any service discovery records making the entire thing useless for us.

Is there a way to have copilot force re-creation of this component? Right now we have to completely delete and rebuild which isn't a sustainable pattern.

I've attached an image of what I'm seeing. There is no errors during init to capture, everything looks "normal" on that front.

image

kohidave commented 3 years ago

Oh no, I'm so sorry for all these issues. I really appreciate your patience and I'll be happy to work through the issues (and create issues in our backlog to fix them).

First, we don't document this well (we will update them though 🙏) but if you don't add a port to your manifest (or have an expose in your Dockerfile at init time), no service discovery endpoint is created. You can add the port to your manifest and you'll service will be recreated with service discovery when you do copilot deploy.

https://aws.github.io/copilot-cli/docs/manifest/backend-service/#image-port

Let me know how that goes!

brogers-propstream commented 3 years ago

Hi there, I'm definitely already exposing my port. But it seems that simply adding it after-the-fact may be the key thing that's breaking this. I initially did not have an expose line, but added it after the fact, yet every copilot deploy thereafter doesn't pick up the change.

I'm trying to regenerate the whole thing again for the third time but I'm running into a seperate issue where co-pilot creates no-op changes and fails to deploy.

kohidave commented 3 years ago

Yea that's a bit confusing. We only read the Dockerfile at init time.

In the meantime you can add the port field directly to your manifest.

When you're deploying you can force it to pick up local changes with copilot deploy --tag {random ID} (this was fixed in the latest version of copilot IIRC)

brogers-propstream commented 3 years ago

@kohidave - To be completely clear. I added it to BOTH not just the docker file.

Right now copilot isn't even allowing me to deploy and is creating empty change sets. Once I get that fixed, I'll try with the tagging method.

brogers-propstream commented 3 years ago

Okay, I think I can reproduce the service discovery issue.

  1. Make sure your deploying for the first time.
  2. Make sure your container fails to initialize - copilot will eventually roll back, but future runs won't register the service.

I have to do B a lot for web services if I don't turn off the healthcheck since copilot will just endlessly spin.