aws / copilot-cli

The AWS Copilot CLI is a tool for developers to build, release and operate production ready containerized applications on AWS App Runner or Amazon ECS on AWS Fargate.
https://aws.github.io/copilot-cli/
Apache License 2.0
3.52k stars 417 forks source link

App Runner : Please support AutoScalingConfiguration settings in manifest.yml #3200

Closed sogaoh closed 2 years ago

sogaoh commented 2 years ago

I want to use min_size of AutoScalingConfiguration setting. I think 1 is default, but I want to increase it to 2. So, please support AutoScalingConfiguration settings in manifest.yml.

refs:

efekarakus commented 2 years ago

Hi @sogaoh 👋

Thank you for the feature request! I think right now the issue is that Copilot is blocked on CloudFormation support: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apprunner-service.html#cfn-apprunner-service-autoscalingconfigurationarn

Today, the autoscaling configuration does not allow an object with MaxSize, MaxConcurrency... and instead strictly an ARN. Once an object as an input is supported in CloudFormation then Copilot can also surface it in the manifest

schm commented 2 years ago

Hey,

I understand that this is blocked by CloudFormation's abilities. But maybe it would be possible to at least expose the AutoScalingConfigurationArn configuration? We can then still set up the configurations manually or using other tools. But then we could reference existing configurations for different services. I would assume, that should be possible today and might not be such a big effort?

I would be looking forward to such a feature.

iamhopaul123 commented 2 years ago

Hello @schm the request makes sense to me. For now we could support the import experience by allowing

count: arn:aws:apprunner:us-east-1:123456789012:autoscalingconfiguration/high-availability/3

in the manifest.

Lou1415926 commented 1 year ago

Hi all 👋🏼 !

We just released v1.24.0. You can now provide the name of an autoscaling configuration for your request-driven web services. Check out our release note for more!

sogaoh commented 1 year ago

@Lou1415926 @efekarakus Hi.

There is no description of count settings on https://aws.github.io/copilot-cli/ja/docs/manifest/rd-web-service/, when do you plan to add it?

hkford commented 1 year ago

Hi @sogaoh Currently we are translating Copilot v1.23 & v1.24 documentation into Japanese. Maybe we could add it by the end of this year.

hkford commented 1 year ago

Now published Copilot v1.24 documentation in Japanese. It includes the count setting. It looks rendering of yaml block is broken and I will fix it soon.