search

aws / copilot-cli

The AWS Copilot CLI is a tool for developers to build, release and operate production ready containerized applications on AWS App Runner or Amazon ECS on AWS Fargate.
https://aws.github.io/copilot-cli/
Apache License 2.0
3.52k stars 414 forks source link

Add support for resourceTags in `copilot env deploy` #3874

Open efekarakus opened 2 years ago

efekarakus commented 2 years ago

Is it feasible to add support for resourceTags for copilot env deploy command at https://github.com/aws/copilot-cli/blob/mainline/internal/pkg/cli/env_deploy.go#L29? This thought is similar to what is currently available for copilot svc deploy command/s at https://github.com/aws/copilot-cli/blob/mainline/internal/pkg/cli/svc_deploy.go#L40.

In general, it could be beneficial to have resourceTags option on multiple cli commands(where feasible) that may allow users to apply custom tags on all the resources which copilot creates or adding tags on resources already created by copilot. Having custom tags is generally a hard requirement at many organizations where users may be expected to tag all the resources. Thoughts?

Discussion

Discussed in https://github.com/aws/copilot-cli/discussions/3872

h5aaimtron commented 1 year ago

@efekarakus I think it would be useful to add custom resource tags for everything from within the manifest as well if possible.

efekarakus commented 1 year ago

@h5aaimtron 👍 would you expect the tags in the environment manifest to apply to all resources within an environment? More specifically for example, would you expect a Load Balanced Web Service to "inherit" the tags in the environment manifest?

h5aaimtron commented 1 year ago

@efekarakus yeah, I guess I would or at least provide a flag to say so. I believe that is how it is working in our CDK stacks.

proof-nicholas commented 1 week ago

Any ETA on this?