search

aws / copilot-cli

The AWS Copilot CLI is a tool for developers to build, release and operate production ready containerized applications on AWS App Runner or Amazon ECS on AWS Fargate.
https://aws.github.io/copilot-cli/
Apache License 2.0
3.52k stars 414 forks source link

Add support for easy deployment of GitHub status checks for the pipeline #3953

Open federicobond opened 2 years ago

federicobond commented 2 years ago

This would be really useful for those of us using GitHub to host our code. It could implement a stack for a system like this: https://aws.amazon.com/es/blogs/devops/aws-codepipeline-build-status-in-a-third-party-git-repository/

huanjani commented 2 years ago

Thanks for the suggestion, @federicobond! We will look into this for sure.

huanjani commented 2 years ago

Related: #3062, #2305, https://zenn-dev.translate.goog/rentio/articles/convox-to-copilot?_x_tr_sl=auto&_x_tr_tl=en&_x_tr_hl=en-US#copilot-pipeline.

federicobond commented 2 years ago

I tried adding the CloudFormation template you mentioned as an addon but deploying the service (even after a delete) just throws me this error:

✘ deploy service web to environment test: deploy service: describe stack events connect-test-web-AddonsStack-2PZA94X64K7G: ValidationError: Stack [connect-test-web-AddonsStack-2PZA94X64K7G] does not exist
        status code: 400, request id: 17681e93-0d7f-48a0-8348-726add1076dc
huanjani commented 2 years ago

🤔 Could you try running the command again and watching in the CloudFormation console to see if the nested stack attempts to create? If it does, please watch in the 'Events' tab to see why it isn't successful?

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no response activity, and is tagged with pending/question. Remove the stale label, add a comment, or this will be closed in 14 days.

huanjani commented 2 years ago

Removing the stale and pending/question labels because the GH status check request still stands.

heyitsmunyr commented 10 months ago

Any progress made on this?

iamhopaul123 commented 10 months ago

@heyitsmunyr I think this should be a feature request for Codebuild/codepipeline: when GH as a source of a pipeline, you can't really turn the badge feature on for codebuild right now. As for now, https://aws.amazon.com/es/blogs/devops/aws-codepipeline-build-status-in-a-third-party-git-repository/ this might be one of the easiest workaround.