search

aws / dcv-color-primitives

DCV Color Primitives Library
MIT No Attribution
30 stars 22 forks source link

Wip/wasm #36

Closed fabiosky closed 4 years ago

fabiosky commented 4 years ago

Issue #, if available: https://github.com/aws/dcv-color-primitives/issues/23 https://github.com/aws/dcv-color-primitives/issues/35

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nacho commented 4 years ago

Looks good to me

Urhengulas commented 4 years ago

And a small other idea would be to use cfg-if for the conditional compilation. Could make it bit cleaner.

Urhengulas commented 4 years ago

Hello @fabiosky :wave:

When do you think this PR will land? I'd like to commit it to our main branch and would prefer a cargo release over a git-dependency.

Are there any blockers I could help with?

fabiosky commented 4 years ago

Hi @Urhengulas ,

I rebased the code above on master, I applied the changes you suggested, except for the cfg-if which will come in a future release.

fabiosky commented 4 years ago

Here's the new release that comes with wasm32 support: https://github.com/aws/dcv-color-primitives/releases/tag/v0.1.14

fabiosky commented 4 years ago

Published on crates too: https://crates.io/crates/dcv-color-primitives

fabiosky commented 4 years ago

This was merged on master. Closing.

Urhengulas commented 4 years ago

Thank you very much for your work @fabiosky!! :smile: