search

aws / dcv-color-primitives

DCV Color Primitives Library
MIT No Attribution
31 stars 22 forks source link

Automatic initialization #78

Closed fabiosky closed 1 year ago

fabiosky commented 1 year ago

Issue #, if available: https://github.com/aws/dcv-color-primitives/issues/66

Description of changes: Perform thread safe and automatic initialization of the library using std::sync::OnceLock.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 1 year ago

Codecov Report

Merging #78 (2ff7327) into master (0f3789f) will decrease coverage by 1.46%. The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   85.90%   84.45%   -1.46%     
==========================================
  Files           8        8              
  Lines        2732     2753      +21     
==========================================
- Hits         2347     2325      -22     
- Misses        385      428      +43
Files Changed Coverage Δ
src/lib.rs 72.34% <82.35%> (-1.64%) :arrow_down:

... and 2 files with indirect coverage changes

pbor commented 1 year ago

I would just remove the deprecated functions... we do not have such a large usage and we are still below 1.0, so let's keep tha API clean.

Also add

rust-version = "1.70"

in Cargo.toml. Cargo now has a official way to document the min rust version