aws / deep-learning-containers

AWS Deep Learning Containers are pre-built Docker images that make it easier to run popular deep learning frameworks and tools on AWS.
https://docs.aws.amazon.com/deep-learning-containers/latest/devguide/what-is-dlc.html
Other
1.01k stars 463 forks source link

[feature-request] Unify aws-id & account-id tag for sagemaker test #692

Open ChaiBapchya opened 4 years ago

ChaiBapchya commented 4 years ago

Checklist

Concise Description: tensorflow pytest on DLC need account-id as parameter https://github.com/aws/deep-learning-containers/blob/c31402d346c644afd17a388eb56cf0ed8e0feabd/test/test_utils/sagemaker.py#L126-L127 while mxnet & pytorch use aws-id

DLC image/dockerfile:

Is your feature request related to a problem? Please describe. I have to switch the arg to be passed to the pytest [for testing on my devbox] for PT/MX: --aws-id for TF: --account-id

Describe the solution you'd like Switch TF to --aws-id since other 2 framework SM tests use that arg.

Describe alternatives you've considered While this isn't a bug, it would be a good dev experience to have unified args.

Additional context NA

ChaiBapchya commented 4 years ago

@saimidu @arjkesh FYI.