search

aws / ec2-macos-init

EC2 macOS Init is the launch daemon used to initialize Mac instances within EC2.
https://aws.amazon.com/ec2/instance-types/mac/
Apache License 2.0
150 stars 19 forks source link

Fix usage of path, replace with filepath #23

Closed jahkeup closed 1 year ago

jahkeup commented 1 year ago

File paths are being joined by the path package in some cases and should instead be using filepath.

https://github.com/aws/ec2-macos-init/blob/f465f4794d23505f39edf1cfa5bb21495438e04b/lib/ec2macosinit/instancehistory.go#L8

This shouldn't be an issue for this codebase as its intended to run on a platform (macOS) that uses / as its separator, so this is more of a "code smell" bug fix issue.

SamMHD commented 1 year ago

@jahkeup, any review?

jahkeup commented 1 year ago

Thanks for the PR! I've assigned some teammates (and myself) to review your changes 👍