Closed jahkeup closed 1 year ago
File paths are being joined by the path package in some cases and should instead be using filepath.
path
filepath
https://github.com/aws/ec2-macos-init/blob/f465f4794d23505f39edf1cfa5bb21495438e04b/lib/ec2macosinit/instancehistory.go#L8
This shouldn't be an issue for this codebase as its intended to run on a platform (macOS) that uses / as its separator, so this is more of a "code smell" bug fix issue.
/
@jahkeup, any review?
Thanks for the PR! I've assigned some teammates (and myself) to review your changes 👍
File paths are being joined by the
path
package in some cases and should instead be usingfilepath
.https://github.com/aws/ec2-macos-init/blob/f465f4794d23505f39edf1cfa5bb21495438e04b/lib/ec2macosinit/instancehistory.go#L8
This shouldn't be an issue for this codebase as its intended to run on a platform (macOS) that uses
/
as its separator, so this is more of a "code smell" bug fix issue.