search

aws / efs-utils

Utilities for Amazon Elastic File System (EFS)
MIT License
297 stars 190 forks source link

Broken amazon-efs-mount-watchdog in v1.35.0: wrongly indented should_check_efs_utils_version #169

Closed Phoosha closed 1 year ago

Phoosha commented 1 year ago

The watchdog does not start at all anymore starting with v1.35.0 due to this commit. I'm getting the following error:

AttributeError: type object 'EFSUtilsVersionChecker' has no attribute 'should_check_efs_utils_version'

This can be fixed by unindenting the method one level. Currently it's a child of the previous method instead of the class:

    @staticmethod
    def check_if_using_old_version(current_version_string):
[...]
        @staticmethod
        def should_check_efs_utils_version(config):
            """Returns True if a customer has enabled the amazon-efs-utils version check,
RyanStan commented 1 year ago

Hi @Phoosha, thanks for pointing this out. Something went wrong in our testing process for this not to be caught. We'll do a thorough internal review to see what happened here.

This change hasn't been merged into a tag release yet and is not part of v1.35.0. Make sure you're pulling v1.35.0 and not master for the time being.

RyanStan commented 1 year ago

A new commit has been pushed to master to fix this issue. We are reviewing our testing process to make sure that this does not happen again. However, we still recommend using the latest tagged release instead of our master.