aws / efs-utils

Utilities for Amazon Elastic File System (EFS)
MIT License
285 stars 187 forks source link

AWS documentation doesn't mention need to install rust/cargo #204

Open thvasilo opened 4 months ago

thvasilo commented 4 months ago

Hello, I was following the instructions here to install the package: https://docs.aws.amazon.com/efs/latest/ug/installing-amazon-efs-utils.html

However at some I was getting the error about cargo not being installed (I'm installing this on an AWS Ubuntu 20.04 DLAMI), should probably update the instruction to install or include cargo installation in the build-dev.sh script.

yambottle commented 4 months ago

Experiencing the same issue...

Suspect the cause of 2.0 release on yesterday(2024/04/12)

The repo README updated:

sudo apt-get update
sudo apt-get -y install git binutils rustc cargo pkg-config libssl-dev
git clone https://github.com/aws/efs-utils
cd efs-utils
./build-deb.sh
sudo apt-get -y install ./build/amazon-efs-utils*deb
augustovoigt commented 4 months ago

Same issue here. We are using Alma Linux 9.3 on our servers, and the efs-utils installation was working fine until yesterday. With the 2.0 release the installation failed because of the missing dependencies (rust, cargo and openssl-devel). The instructions on https://docs.aws.amazon.com/efs/latest/ug/installing-amazon-efs-utils.html need to be updated.

thvasilo commented 4 months ago

The instructions in the readme on the repo work, just need to install a couple of extra dependencies, it's just the AWS docs that need to be updated.

jakevose commented 4 months ago

This compilation is adding several minutes to our builds after updating the dependencies. Will be locking the version to 1.36.0 for the immediate future.

major commented 4 months ago

On the Fedora side, we might be stuck on 1.36.0 for a while as well. 🤔

RyanStan commented 4 months ago

We're updating the instructions on https://docs.aws.amazon.com/efs/latest/ug/installing-amazon-efs-utils.html. These will be out shortly. For now, the updated installation instructions are available in the readme.

@major Can you open up a new issue where we can track the problems with distributing this release on Fedora?

@jakevose We can look into ways in which we can decrease the build time. Can you open a new issue and provide some details about how your builds work? E.g. spinning up new hosts in an autoscaling group and building efs-utils via the user data script? We can help come up with a temporary solution that mitigates the longer build time problem.

justin-octo commented 4 months ago

This has also broken things for CentOS 7

aiqc commented 1 month ago

Boo. You know developers are building ubuntu images on old stable releases that don't have Rust. Why add this dependency?


Putting this here for future people debugging via google search:

When installing efs-utils via docker RUN ./build-deb.sh;:

+ cargo build --release --manifest-path /my-path/efs-utils/src/proxy/Cargo.toml
./build-deb.sh: 33: cargo: not found

Within ./build-deb.sh script:

cargo build --release --manifest-path ${BASE_DIR}/src/proxy/Cargo.toml