search

aws / eks-anywhere-build-tooling

Build artifacts for upstream dependencies of Amazon EKS Anywhere - https://github.com/aws/eks-anywhere
https://anywhere.eks.amazonaws.com
Apache License 2.0
56 stars 90 forks source link

Skip CAPI upgrade on release branches #4014

Closed sp1999 closed 6 days ago

sp1999 commented 6 days ago

Description of changes: We have observed in the past that CAPI sometimes introduces breaking changes even for patch releases. Due to this, all our tests failed when we upgraded the CAPI patch version on a release branch. So, we decided not to upgrade CAPI anymore on release branches unless some customer requires some critical fix and they are still on a supported release branch. This PR updates the project upgrader tool to skip upgrading CAPI on release branches.

Testing:

make -C tools/version-tracker build

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sp1999 commented 6 days ago

/approve

sp1999 commented 6 days ago

/cherry-pick release-0.21

eks-distro-pr-bot commented 6 days ago

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you.

In response to [this](https://github.com/aws/eks-anywhere-build-tooling/pull/4014#issuecomment-2461026338): >/cherry-pick release-0.21 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sp1999 commented 6 days ago

/cherry-pick release-0.20

eks-distro-pr-bot commented 6 days ago

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to [this](https://github.com/aws/eks-anywhere-build-tooling/pull/4014#issuecomment-2461026414): >/cherry-pick release-0.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
eks-distro-bot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/aws/eks-anywhere-build-tooling/blob/main/OWNERS)~~ [abhay-krishna,sp1999] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
abhay-krishna commented 6 days ago

/lgtm

eks-distro-pr-bot commented 6 days ago

@sp1999: new pull request created: #4015

In response to [this](https://github.com/aws/eks-anywhere-build-tooling/pull/4014#issuecomment-2461026338): >/cherry-pick release-0.21 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
eks-distro-pr-bot commented 6 days ago

@sp1999: new pull request created: #4016

In response to [this](https://github.com/aws/eks-anywhere-build-tooling/pull/4014#issuecomment-2461026414): >/cherry-pick release-0.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.