search

aws / eks-anywhere-packages

Apache License 2.0
25 stars 27 forks source link

Remove promo flag and other dependent flags from the generatebundlefile CLI #1150

Closed sp1999 closed 1 month ago

sp1999 commented 2 months ago

Description of changes:

This PR removes the following flags from the generatebundlefile CLI as they are no longer being used anywhere

The regionCheck flag was being used only for non-regional packages release pipelines to verify that the bundles existed in the non-regional supported AWS regions listed here within the AWS Regions table. As we have migrated all the packages build and release pipelines to the regional packages beta account, we don't need this flag anymore.

The promo codebuild job is no longer required to promote the helm charts, bundles and certain images to public ECR as it is now being handled by the ECR Image replication job in all the packages build and release pipelines. So we are removing the promote flag from the CLI. All the remaining flags mentioned above were being used by the promote flag so they are also being removed as a result. Since there is just one account where we handle everything, we don't need any profile variables and so the corresponding publicProfile and privateProfile flags are also being removed.

In addition to that, this PR also removes lot of unused and unnecessary helper functions along with updating any go package dependencies in go.mod file. It also updates a lot of error messages to improve the logs for better debugging. For ex:- removing punctuation or new line characters at the end of the error message, updating error messages to not start with capital letters or "Error" keyword, etc

Testing: make build

abhay-krishna commented 1 month ago

/lgtm /approve

eks-distro-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/aws/eks-anywhere-packages/blob/main/OWNERS)~~ [abhay-krishna,sp1999] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment